[weekly-r319] MemPostings: keep a map of label values slices (#15426) #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating lock contention on `MemPostings`, we saw that lots of locking is happening in `LabelValues` and `PostingsForLabelsMatching`, both copying the label values slices while holding the mutex. This adds an extra map that holds an append-only label values slice for each one of the label names. Since the slice is append-only, it can be copied without holding the mutex. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Dec 2, 2024
Updates mimir-prometheus weekly-r319 to grafana/mimir-prometheus#779 This includes the cherry-pick of prometheus/prometheus#15426 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Dec 2, 2024
Updates mimir-prometheus weekly-r319 to grafana/mimir-prometheus#779 This includes the cherry-pick of prometheus/prometheus#15426 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of prometheus/prometheus#15426 into weekly-r319, as main isn't up to date with prometheus/main yet.
#778 was accidentally merged into main (which isn't a big deal, we're going to bring it through the usual merge process anyway)